Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting Command(Ctrl) + S on in an RTC notebook results in a "File Changed" dialog #312

Open
ibdafna opened this issue May 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ibdafna
Copy link
Member

ibdafna commented May 9, 2024

See attached gif

rtc-ctrl-s

@ibdafna ibdafna added the bug Something isn't working label May 9, 2024
@andypfau
Copy link

andypfau commented May 20, 2024

Same here. I have a docker container (based on python:bullseye) with only Jupyter Lab (v. 4.2.0) and the jupyter-collaboration extension.

Observations:

  • You can either click "Revert" or "Overwrite", and it seems to work.
  • It is nevertheless annoying.
  • You may also close the editor, and rename it on the file browser, in which case it works as expected (no error dialog).
  • You may click "Do not ask me again", in which case you are in the future forced to rename it via the file browser.

One workaround seems to be to add this snippet to /usr/local/share/jupyter/lab/settings/overrides.json (see https://jupyterlab.readthedocs.io/en/latest/user/directories.html#jupyterlab-user-settings-directory), which essentially does the same as "do not ask me again". Users will be forced to rename using the file browser, which at least might be less confusing than seeing an error everytime they want to rename a new document:

{
    "@jupyterlab/docmanager-extension:plugin": {
        "renameUntitledFileOnSave": false
    }
}

However, that is just an ad-hoc workaround. A cleaner solution would be nice :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants