Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backspace not propagating to clients in the same room #308

Open
ibdafna opened this issue May 8, 2024 · 4 comments
Open

Backspace not propagating to clients in the same room #308

ibdafna opened this issue May 8, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ibdafna
Copy link
Member

ibdafna commented May 8, 2024

When typing something in a cell, and then hitting the backspace key to delete some of the content, the deleted keystrokes do not propagate to others viewing the notebook. See attached gif.

This is happening for me on JupyterLab 4.0.x/4.1.x/4.2.x, and jupyter-collaboration==4.1.1. Downgrading to 2.0.11 doesn't solve the problem, which makes me think it's likely in one of the transient dependencies of jupyter-collaboration.

collab-issue-backspace

@ibdafna ibdafna added the bug Something isn't working label May 8, 2024
Copy link

welcome bot commented May 8, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@Zsailer
Copy link
Member

Zsailer commented May 8, 2024

Thanks @ibdafna. I can reproduce this issue with latest jupyterlab and jupyter-collaboration as well.

@jzhang20133
Copy link
Collaborator

jzhang20133 commented May 9, 2024

This issue does not reproduce for pycrdt<=0.8.23, but reproduce when pycrdt==0.8.24. cc @ibdafna @Zsailer @davidbrochart

@davidbrochart
Copy link
Collaborator

Thanks, I've yanked pycrdt v0.8.24 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants