Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt AnyIO #252

Open
davidbrochart opened this issue Mar 15, 2024 · 1 comment
Open

Adopt AnyIO #252

davidbrochart opened this issue Mar 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@davidbrochart
Copy link
Collaborator

Problem

I'm seeing this error due to aiosqlite, for instance in the CI:

Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.11.8\x64\Lib\threading.py", line 1045, in _bootstrap_inner
    self.run()
  File "C:\hostedtoolcache\windows\Python\3.11.8\x64\Lib\site-packages\aiosqlite\core.py", line 120, in run
    future.get_loop().call_soon_threadsafe(set_exception, future, e)
  File "C:\hostedtoolcache\windows\Python\3.11.8\x64\Lib\asyncio\base_events.py", line 807, in call_soon_threadsafe
    self._check_closed()
  File "C:\hostedtoolcache\windows\Python\3.11.8\x64\Lib\asyncio\base_events.py", line 520, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

I also saw this kind of errors in Jupyverse, where I'm switching to sqlite-anyio (here).

Proposed Solution

In general, jupyter-collaboration could benefit from structured concurrency, just like pycrdt-websocket did.

@davidbrochart davidbrochart added the enhancement New feature or request label Mar 15, 2024
@dlqqq
Copy link
Collaborator

dlqqq commented Mar 20, 2024

Found a possibly related upstream issue: omnilib/aiosqlite#241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants