Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening from "running" panel does not use collaborative mode #242

Open
Zsailer opened this issue Feb 28, 2024 · 3 comments
Open

Opening from "running" panel does not use collaborative mode #242

Zsailer opened this issue Feb 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Zsailer
Copy link
Member

Zsailer commented Feb 28, 2024

Description

If you click on the document in the "Running" panel, you will open a non-collaborative Notebook view.

Reproduce

  1. Open a notebook from the file-browser (or start a new notebook)
  2. Go to the "Running" left panel.
  3. Click on that same notebook from this panel.
  4. You will get a second view of the Notebook that is not in collaborative mode.

Expected behavior

Opening a document from the "Running" panel should also open in collaborative model.

@Zsailer Zsailer added the bug Something isn't working label Feb 28, 2024
Copy link

welcome bot commented Feb 28, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@davidbrochart
Copy link
Collaborator

Thanks Zach, it's probably because of the RTC: prefix of the custom YDrive. This has been a major source of issues, as a lot of JupyterLab extensions don't handle Jupyter drives, and even in JupyterLab core this is not a well supported feature.
In the long run, I think it will require making the JupyterLab default drive a proper drive. But we can fix this issue with the running panel before that.

@Zsailer
Copy link
Member Author

Zsailer commented Feb 29, 2024

Thanks @davidbrochart. That's right. We noticed the prefix isn't used when opening from the running panel.

Do we fix this in JupyterLab core now, in the running-extension? Or is this a Jupyter-collaboration plugin that replaces the necessary parts of the running-extension when RTC is enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants