Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect example for model ID in the HfHubProvider #738

Closed
krassowski opened this issue Apr 20, 2024 · 1 comment
Closed

Incorrect example for model ID in the HfHubProvider #738

krassowski opened this issue Apr 20, 2024 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@krassowski
Copy link
Member

Description

The help message suggests

help = (
"See [https://huggingface.co/models](https://huggingface.co/models) for a list of models. "
"Pass a model's repository ID as the model ID; for example, `huggingface_hub:ExampleOwner/example-model`."

but passing it in this format results in:

pydantic.v1.error_wrappers.ValidationError: 1 validation error for HfHubProvider
__root__
  Repo id must use alphanumeric chars or '-', '_', '.', '--' and '..' are forbidden, '-' and '.' cannot start or end the name, max length is 96: 'huggingface_hub:ExampleOwner/example-model'. (type=value_error.hfvalidation)

Removing huggingface_hub: works. The error message from upstream is confusing though.

Also there is a warning:

site-packages/huggingface_hub/utils/_deprecation.py:131: FutureWarning: 'InferenceApi' (from 'huggingface_hub.inference_api') is deprecated and will be removed from version '1.0'. `InferenceApi` client is deprecated in favor of the more feature-complete `InferenceClient`. Check out this guide to learn how to convert your script to use it: https://huggingface.co/docs/huggingface_hub/guides/inference#legacy-inferenceapi-client.
@krassowski krassowski added the bug Something isn't working label Apr 20, 2024
@krassowski
Copy link
Member Author

Closing as a duplicate of #576

@krassowski krassowski added the duplicate This issue or pull request already exists label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

1 participant