Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter-releaser bumps version two times #732

Open
brichet opened this issue Apr 13, 2024 · 1 comment
Open

Jupyter-releaser bumps version two times #732

brichet opened this issue Apr 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@brichet
Copy link

brichet commented Apr 13, 2024

Description

As noticed by @krassowski in jupyterlab/jupyter-chat#15, the releaser bumps the version 2 times in the workflow, with the current settings.

Related issue: jupyter-server/jupyter_releaser#567

Some logs from a recent check-release run:

Changes:
 - @jupyter-ai/monorepo: 2.13.0 => 2.14.0 (private)
 - @jupyter-ai/magics: 2.13.0 => 2.14.0 (private)
 - @jupyter-ai/core: 2.13.0 => 2.14.0

lerna info auto-confirmed
lerna info execute Skipping git tag/commit
lerna info execute Skipping git push
lerna info execute Skipping releases
lerna success version finished
Setting up build environment for missing dependencies
2.14.0
2.14.0
COMMAND: ../../scripts/bump-version.sh minor
lerna notice cli v6.4.1
lerna info ci enabled
lerna info current version 2.14.0
lerna notice FYI git repository validation has been skipped, please ensure your version bumps are correct
lerna WARN force-publish all packages
lerna info Assuming all packages changed
lerna info version rooted leaf detected, skipping synthetic root lifecycles
lerna WARN version Skipping working tree validation, proceed at your own risk

Changes:
 - @jupyter-ai/monorepo: 2.14.0 => 2.15.0 (private)
 - @jupyter-ai/magics: 2.14.0 => 2.15.0 (private)
 - @jupyter-ai/core: 2.14.0 => 2.15.0

Reproduce

run the check-release workflow.

Expected behavior

To bump version only once.

@brichet brichet added the bug Something isn't working label Apr 13, 2024
@dlqqq
Copy link
Collaborator

dlqqq commented Apr 15, 2024

I had noticed this as well very early on, which is why this repo uses a custom bump-version.sh that is idempotent, i.e. it uses the correct version even if run multiple times. There should be an existing issue here to track this, but I don't have the time to dig it up right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants