Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Implement paging for variables #398

Open
jtpio opened this issue Mar 16, 2020 · 9 comments
Open

Implement paging for variables #398

jtpio opened this issue Mar 16, 2020 · 9 comments
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Mar 16, 2020

At the moment the variable table will show a Too large to show contents. Max items to show: 300 message if a user decides to show a list with more than 300 entries:

image

The DAP supports startand count for the variables request, which can be using to implement paging: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Variables

@jtpio jtpio added this to the 0.3.0 milestone Mar 16, 2020
@jtpio
Copy link
Member Author

jtpio commented Mar 16, 2020

VS code currently shows the same message when defining ls = list(range(1000)):

image

@afshin
Copy link
Member

afshin commented Mar 27, 2020

If we use a @lumino/datagrid and it supports an arbitrary number of variables, does this solve our issue or are we concerned about too much data being sent across the wire?

@afshin
Copy link
Member

afshin commented Mar 27, 2020

We should probably use a streaming adapter to make sure we don't get flooded and to accommodate the paging built into the debug adapter protocol.

@afshin
Copy link
Member

afshin commented Mar 27, 2020

@jtpio
Copy link
Member Author

jtpio commented Mar 27, 2020

Using the streaming adapter sounds good 👍

I quickly tried using the start and count parameters the other day, but they didn't seem to be taken into account. Maybe that's something we need to tweak on the ptvsd side.

@jtpio
Copy link
Member Author

jtpio commented Mar 31, 2020

As a start, there could be a new test that makes use of the start and count parameters in:

https://github.com/jupyterlab/debugger/blob/master/tests/src/session.spec.ts

@KrzysztofSikoraCodete
Copy link
Contributor

There is no support for pagination, probably...
#415

Any suggestions?

@JohanMabille
Copy link
Member

JohanMabille commented Apr 3, 2020

This limitation of 300 variables comes from pydev itself. debugpy, the drop-in replacement for ptvsd also vendors pydev and has the same issue.

EDIT: I opened an issue to remove it (or get the ability to set it from the outside).

@jtpio jtpio modified the milestones: 0.3.0, Future Jul 13, 2020
@jtpio
Copy link
Member Author

jtpio commented Jul 13, 2020

Moving to Future as the limit of 300 variables is still in debugpy / pydev.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants