Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Handle errors #147

Open
jtpio opened this issue Nov 4, 2019 · 0 comments
Open

Handle errors #147

jtpio opened this issue Nov 4, 2019 · 0 comments
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Nov 4, 2019

At the moment we wrap the debug requests in try catch blocks, and log the errors to the console:

debugger/src/service.ts

Lines 109 to 118 in 80fb3d7

async continue(): Promise<void> {
try {
await this.session.sendRequest('continue', {
threadId: this.currentThread()
});
this._threadStopped.delete(this.currentThread());
} catch (err) {
console.error('Error:', err.message);
}
}

Instead we should handle the error properly, for example by showing an error message to the user.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant