Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening notebooks as notebooks, rather than as text files? #79

Open
krassowski opened this issue Jul 15, 2022 · 2 comments
Open

Opening notebooks as notebooks, rather than as text files? #79

krassowski opened this issue Jul 15, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@krassowski
Copy link

Opening files with matches from the sidebar is fine, but notebooks open as files for me. Scrolling to the cell with match should be easy enough when the match is in the cell. Is this a bug/something specific to my setup, or is it just not implemented?

Additional context

  • Python package version: 1.0.1
  • JupyterLab 3.4.3 but also seen that in a much older version
@krassowski krassowski added the enhancement New feature or request label Jul 15, 2022
@fcollonval
Copy link
Member

Thanks for the suggestion @krassowski.

That choice was made on purpose as the underlying tool (riggrep) can only deal with plain text file.

It is definitely possible to do something smarter. But it will require implementing a kind of registry for file types that will support a different behavior for opening a file and going to a specific match (with the ability to pick the default viewer).

@fcollonval
Copy link
Member

Xref #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants