Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.0.0 breaks JupyterLite support #82

Open
jtpio opened this issue Nov 29, 2023 · 3 comments
Open

Version 4.0.0 breaks JupyterLite support #82

jtpio opened this issue Nov 29, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@jtpio
Copy link
Member

jtpio commented Nov 29, 2023

Description

As noticed in jupyterlite/jupyterlite#1258 (comment) and #76 (comment), the new JupyterLab 4 compatible version does not seem to work

Reproduce

For example testing with ReadTheDocs preview for jupyterlite/jupyterlite#1258: https://jupyterlite--1258.org.readthedocs.build/en/1258/_static/lab/index.html

Expected behavior

jupyterlab-tour was running fine with JupyterLite before.

Looks like this might be related to some new server side logic introduced recently in #81? Could this be made optional to keep JupyterLite support?

@jtpio jtpio added the bug Something isn't working label Nov 29, 2023
@fcollonval
Copy link
Member

The latest version is now using the api/config endpoint from Jupyter Server to store the tours seen independently of the workspaces.

From the demo 1258 you are linking I see the tours are working. I guess the fix should be on Lite to implement the handling of the standard config REST endpoint.

@jtpio
Copy link
Member Author

jtpio commented Dec 5, 2023

JupyterLite does not implement all the Jupyter Server endpoints (for example there is no api/terminals or api/me) Up until now api/config has not been needed. So I was wondering if there could be way to get away without having to implement it, just like it was the case with the previous version of jupyterlab-tour.

store the tours seen independently of the workspaces.

What issue does this cause?

@jtpio
Copy link
Member Author

jtpio commented Dec 5, 2023

From the demo 1258 you are linking I see the tours are working.

They seem to be working but only partially?

For example the tours are not in the command palette anymore:

image

And they seem to be greyed out afterwards in the help menu:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants