Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick access to creating a seperate browser tab which only comprises of the video chat #44

Closed
honno opened this issue Jul 23, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@honno
Copy link

honno commented Jul 23, 2021

Was using this nifty tool for the first time thanks to @tonyfast and folks inside a RTC Jupyter Labs session. As someone who's not familiar with Jupyter stuff outside of basic IPython cells, the experience was a bit too fun in that I found it hard to contextualise everything else going on in the Labs environment.

I'm sure I could of played around with the current sidebar feature and stuff but maybe there is room to improve that first-time user experience somehow. For example, if there was a button somewhere that would create a new tab that was just the video chat ala Google Meet.... just a first thought!

@honno honno added the enhancement New feature or request label Jul 23, 2021
@bollwyvl
Copy link
Collaborator

Thanks for the interest.

Opening in another tab introduces a number of challenges from a future API integration point of view (e.g. #5, #24), but is probably feasible... but would not be my first choice as a default, however FANGMA does it. The ability to look at someone while doing something else is one of the features of having it in lab in the first place. Someone who's throwing you into a Lab session and piling Jitsi on top of it is being rather cavalier with your attention.

Under the hood, the thing's just an iframe, which should be openable as a new tab via right click... though Jitsi may have overloaded it (much like lab itself does) requiring a Ctrl+Shift+Click to get at it.

@bollwyvl
Copy link
Collaborator

The user story this might jive with is I'm using Jupyter for the first time with retrolab: in some (accidental) tests, we found that it pretty much works without any special case, though it's:

  • non-obvious how to get to it
  • got some CSS issues (the chat is about 200px tall)

@bollwyvl
Copy link
Collaborator

bollwyvl commented Jul 25, 2021

Without too much jiggery-pokery, this looks okay:

what it looks like
add a New Video Chat button (also under _File->New) Screenshot from 2021-07-25 16-26-48
the pre-lobby Screenshot from 2021-07-25 16-25-13
in the chat Screenshot from 2021-07-25 16-24-49
in zen mode Screenshot from 2021-07-25 16-28-29

@bollwyvl
Copy link
Collaborator

Mostly working... #41 has a static one that you can try out right now:

https://jupyter-videochat--41.org.readthedocs.build/en/41/_static/lite/retro/tree/

@bollwyvl
Copy link
Collaborator

bollwyvl commented Apr 3, 2022

Fixed in v0.6.0.

@bollwyvl bollwyvl closed this as completed Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants