Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt 'enforce-labels' GitHub action from JupyterLab team #683

Open
yuvipanda opened this issue Oct 5, 2023 · 5 comments
Open

Adopt 'enforce-labels' GitHub action from JupyterLab team #683

yuvipanda opened this issue Oct 5, 2023 · 5 comments

Comments

@yuvipanda
Copy link
Collaborator

Inspired by this comment (jupyterhub/kubespawner#793 (comment)) from @consideRatio, where adding labels to PRs is very helpful in creating changelogs. The JupyterLab team has a GH workflow
(https://github.com/jupyterlab/jupyterlab/blob/main/.github/workflows/enforce-label.yml) that ensures this happens on all PRs, and surfaces it more explicitly when it's not.

We could adopt this as a way to minimize toil during releases, where the person doing releases might have to go and relabel old PRs.

@minrk
Copy link
Member

minrk commented Oct 6, 2023

I like having this as a reminder for the PR merger. The only thing I don't like is seeing that red X as a PR contributor for something entirely out of my control and irrelevant to my contribution (when contributing to repos I don't have labeling permission on, that is). Maybe most folks don't get the same "You've done something wrong" visceral reaction from the red X that I do?

@sgibson91
Copy link
Member

Agree with Min - it would be nice if, instead of failure, it added a "to-be-traiged" label, or left a "To the Reviewer, please add labels" comment. Which is something we could try to contribute to the action, under a feature flag or something.

@yuvipanda
Copy link
Collaborator Author

yeah i don't like the big red either.

+1 on moving it to a comment, perhaps one that even gets autodeleted after? I think that's how other projects do it

@minrk
Copy link
Member

minrk commented Oct 6, 2023

I like the affirmative triage label, since that's easiest to look for, since you can visit is:merged label:triage to quickly view all the PRs that need a label (is:merged -label:bug OR -label:enhancement... is a lot harder)

@manics
Copy link
Member

manics commented Oct 6, 2023

I like the idea of using labels too, it avoids sending comment notifications to everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants