Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CILogon] Make CILogon's username_claim callable for consistency across authenticators #728

Open
consideRatio opened this issue Feb 7, 2024 · 0 comments
Labels

Comments

@consideRatio
Copy link
Member

Before #717 GenericOAuthenticator was the odd duck allowing username_claim to be callable, but after that PR CILogonOAuthenticator becomes the odd dock by not allowing its username_claim implementation to be callable.

For consistency, we should make it callable, and by doing that resolve #712 by doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant