Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standarize dictionary keys for storing user groups/teams/organizations in auth state? #618

Open
consideRatio opened this issue Jun 13, 2023 · 2 comments

Comments

@consideRatio
Copy link
Member

Extracted from #594 and #594 (comment).

  • open issue about standardizing a flag like populate_teams_in_auth_state in all authenticators and the naming for the teams key, holding the info about the teams the user is a member of. (Eg. in bitbucket.py the key is called user_teams and we set it by default without any flag, but in github.py we have a flag and call it teams). Consider allowed_orgs too as for standadization.
@consideRatio
Copy link
Member Author

I see the value of standarizing this mainly stems from that the logic in this project can be simplified, but I value not doing it because it would be a breaking change.

I'm currently weighing pro/con's to think that this isn't worth pursuing, at least not for the next major release (oauthenticator 16).

@GeorgianaElena GeorgianaElena changed the title Standarize diciontary keys for storing user groups/teams/organizations in auth state? Standarize dictionary keys for storing user groups/teams/organizations in auth state? Jun 14, 2023
@minrk
Copy link
Member

minrk commented Jun 20, 2023

I'm currently weighing pro/con's to think that this isn't worth pursuing, at least not for the next major release (oauthenticator 16).

If it helps simplify things, we can go ahead. The breaking change can be avoided by populating both fields for a time and deprecating the old field, if that is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants