Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect_uri not the same as oauth_callback_url #520

Open
endritdemaj opened this issue Jun 13, 2022 · 1 comment
Open

redirect_uri not the same as oauth_callback_url #520

endritdemaj opened this issue Jun 13, 2022 · 1 comment

Comments

@endritdemaj
Copy link

Proposed change

File: oauthenticator/oauthenticator/oauth2.py

Hi all,

im having a issue where the redirect_uri is not the same as the oauth_callback_url. Therefor after succesfully logging in im getting a 404 error from HUB since the uri doesn't exist on the HUB side.

Alternative options

Currently no alternative

Who would use this feature?

Everyone who does not have the same oauth_callback_url and redirect_uri

(Optional): Suggest a solution

 def get_redirect_uri(self, handler=None):
        """Get my OAuth redirect URL
        Either from config or guess based on the current request.
        """
        if self.redirect_uri:
            return self.redirect_uri
       ....

redirect_uri = self.authenticator.get_redirect_uri(self)
@welcome
Copy link

welcome bot commented Jun 13, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant