Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal Dockerfile example yields broken notebook (404: not found) on mybinder.org #240

Open
N-Coder opened this issue Sep 15, 2021 · 7 comments
Labels

Comments

@N-Coder
Copy link
Contributor

N-Coder commented Sep 15, 2021

Opening any of the two binder links of the minimal Dockerfile example yields a notebook that simply displays a 404 error page:
image
Binder master branch
Binder truly-minimal branch
Running jupyter-repo2docker https://github.com/binder-examples/minimal-dockerfile locally yields a working notebook.

@N-Coder N-Coder added the bug label Sep 15, 2021
@welcome
Copy link

welcome bot commented Sep 15, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@manics
Copy link
Member

manics commented Sep 15, 2021

That'll be due to the default URL changing to jupyterlab jupyterhub/binderhub#1354

Options are to either change the binder badge to pass /tree as the starting URL, or to install JupyterLab in the minimal Dockerfile.

@N-Coder
Copy link
Contributor Author

N-Coder commented Sep 15, 2021

I also get the same problem when pasting the link to the GitHub repo on the mybinder.org starting page, so it's probably all links that are generated there: https://mybinder.org/v2/gh/binder-examples/minimal-dockerfile/HEAD
image

@betatim
Copy link
Member

betatim commented Sep 15, 2021

mybinder.org will try to send you to the URL at which JupyterLab is, but because the minimal example doesn't install JupyterLab you get a 404. This means that the minimal example needs updating so that it installs Jupyter Lab. Do you want to tackle that in a PR to https://github.com/binder-examples/minimal-dockerfile?

@N-Coder
Copy link
Contributor Author

N-Coder commented Sep 15, 2021

So that basically means that Docker Containers without JupyterLab are no longer really supported on mybinder.org?
I guess then there are also some parts of the documentation that should be updated to reflect this, especially here and here.
One could either remove the part about only installing notebook or make the information about how to switch between both versions more promininent with a warning on both pages saying that you'll need to manually fix your URLs.

@betatim
Copy link
Member

betatim commented Sep 16, 2021

So that basically means that Docker Containers without JupyterLab are no longer really supported on mybinder.org?

Not quite. You can make a container that doesn't have lab installed but then you will have to specify the URL that users should be redirected to because the default URL is the one JupyterLab uses.

Yes, there are unfortunately a lot of places in the docs that need updating that haven't yet been updated.

@N-Coder
Copy link
Contributor Author

N-Coder commented Sep 17, 2021

I opened PRs in #243, binder-examples/minimal-dockerfile#4 and binder-examples/minimal-dockerfile#5, feel free to edit them as you deem suitable. I also didn't update the example overview page, as that probably needs the other PRs merged and I currently have no environment at hand to actually run the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants