Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we testing against JupyterHub 1.3? #833

Open
consideRatio opened this issue Apr 24, 2024 · 0 comments
Open

Are we testing against JupyterHub 1.3? #833

consideRatio opened this issue Apr 24, 2024 · 0 comments

Comments

@consideRatio
Copy link
Member

consideRatio commented Apr 24, 2024

It seems we have fixture that creates a jupyterhub pod with the version hardcoded to jupyterhub 1.3.

We should make our tests test against the version of jupyterhub we expect it to be tested against.

pod_manifest = V1Pod(
metadata={
"name": pod_name,
"labels": {"component": "hub", "hub-name": pod_name},
},
spec=V1PodSpec(
volumes=volumes,
containers=[
{
"image": "jupyterhub/jupyterhub:1.3",

include:
# Tests with oldest supported Python, jupyterhub, k8s, and k8s client
#
# NOTE: If lower bounds are updated, also update our test for the
# lower bounds in pyproject.toml.
#
- python: "3.7"
k3s: v1.24
test_dependencies: >-
jupyterhub==4.0.0
kubernetes_asyncio==24.2.3
# Test with modern python and k8s versions
- python: "3.11"
k3s: v1.27
- python: "3.12"
k3s: v1.28
# Test with latest python and JupyterHub in main branch
- python: "3.X"
k3s: latest
test_dependencies: git+https://github.com/jupyterhub/jupyterhub


Confusion points for me are currently:

  • We are installing jupyterhub locally, but we also in our test suite start a jupyterhub pod with version 1.3. How is the hub pod used compared to the local jupyterhub software in our test suite?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant