Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document rewrite_response #474

Open
ryanlovett opened this issue Apr 15, 2024 · 0 comments
Open

Document rewrite_response #474

ryanlovett opened this issue Apr 15, 2024 · 0 comments
Labels

Comments

@ryanlovett
Copy link
Collaborator

Bug description

rewrite_response was added in #209 to enable proxies to dynamically alter the response to the client. This is a very cool feature and other projects like jupyter-rsession-proxy make use of it, but it is not documented.

How to reproduce

  1. Go to https://jupyter-server-proxy.readthedocs.io/
  2. Search for rewrite_response
  3. Find nothing except for mentions in the changelog

Expected behaviour

Because I know the feature exists, I expected to find documentation for it. Others wouldn't know to search for it unless they were browsing the source code.

@ryanlovett ryanlovett added the bug label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant