Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest-jupyter fixtures in unit testing #406

Open
mahendrapaipuri opened this issue Apr 28, 2023 · 0 comments
Open

Use pytest-jupyter fixtures in unit testing #406

mahendrapaipuri opened this issue Apr 28, 2023 · 0 comments

Comments

@mahendrapaipuri
Copy link

Proposed change

In a recent PR #396, unit testing is changed from running a external JupyterLab server to running the server via fixtures. This is already a good contribution as we do not need to run anything manually to do testing. The downside is that tests take way longer now as each test is spinning up a jupyter server (I guess?)

Aren't we supposed to use pytest-jupyter fixtures for this use cases? We have jp_fetch fixture which is what we need to test our cases. There is also sibling jp_ws_fetch for WS connection. We can use them "out-of-the-box" in the unit tests. I have tested them locally , they work fine and they are way faster. Is there any specific reason why these fixtures are not being used?

If not, I can put up a PR.

Who would use this feature?

Anyone who is contributing to the JSP project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant