Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate ./contrib to a new github repository like jupyterhub/jupyter-server-proxy-contrib? #251

Open
manics opened this issue Feb 19, 2021 · 1 comment

Comments

@manics
Copy link
Member

manics commented Feb 19, 2021

https://github.com/jupyterhub/jupyter-server-proxy/tree/v3.0.0-rc.1/contrib contains additional mini-python projects that aren't tested or published by our standard CI workflows. This has several consequences:

  • Not tested!
  • We've unified the release process for the Python jupyter-server-proxy and NPM @jupyterlab/server-proxy packages but contrib falls outside of this release process, and in any case they're independently versioned.
  • If we did make changes to contrib they'd either appear in the CHANGELOG for jupyter-server-proxy even though they're not released as part of jupyter-server-proxy, or we'd have to manually remove them.
  • If more projects are added to contrib in future this becomes even more complicated
  • They're a bit hidden away, if you see this repo it's not obvious there are some hidden repos inside, maybe that's why there aren't many contributions?

How does everyone feel about moving the contents of contrib to a new repository jupyterhub/jupyter-server-proxy-contrib. Or do you have some other ideas?

@ryanlovett
Copy link
Collaborator

I'm in favor of putting the theia contribution into its own repo and then documenting it in the examples section. The code-server-traitlet could be reproduced entirely in the docs, or put in a gist and then linked to from the docs.

@consideRatio consideRatio changed the title Move contrib into a new repository Relocate ./contrib to a new github repository like jupyterhub/jupyter-server-proxy-contrib? Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants