Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in proxy? #388

Open
snickell opened this issue Apr 7, 2022 · 11 comments
Open

Memory leak in proxy? #388

snickell opened this issue Apr 7, 2022 · 11 comments
Labels

Comments

@snickell
Copy link

snickell commented Apr 7, 2022

Aloha, we've been seeing a pattern of growing daily memory usage (followed by increasing slugishness then non-responsiveness above around 1-2GB of RAM) in the 'proxy' pod:
image

The different colors are fresh proxy reboots, which have been required to keep the cluster running.

Screen Shot 2022-04-07 at 5 01 00 AM

-Seth

@snickell snickell added the bug label Apr 7, 2022
@snickell
Copy link
Author

snickell commented Apr 7, 2022

Sorry, clipped the units:
image

The pattern is nearly identical on the other cluster.

@snickell
Copy link
Author

snickell commented Apr 7, 2022

We're running z2jh chart version 1.1.3-n354.h751bc313 (I believe the latest ~3 weeks ago), but as you can see, this pattern predates this chart version by quite a bit.

@consideRatio consideRatio transferred this issue from jupyterhub/zero-to-jupyterhub-k8s Apr 7, 2022
@snickell
Copy link
Author

snickell commented Apr 7, 2022

We start seeing serious performance problems at about 1.5GB, which is suspiciously close to the heap limit for node 🤔 So maybe its a memory leak that then cascade fails at the heap limit into some sort of .... garbage collection nightmare? or?

@manics
Copy link
Member

manics commented Apr 7, 2022

Do you happen to know if the memory increases are correlated with particular events, e.g. a user starting a new server, or connecting to a particular service?

@snickell
Copy link
Author

snickell commented Apr 7, 2022

No, but I'm looking into it, my vague suspicion: websockets? We push them pretty hard, e.g. many users are streaming VNC over websocket. Is there a log mode that has useful stats about e.g. the routing table?

@snickell
Copy link
Author

OK, so a further development, since high RAM usage correlated with performance problems, I added a k8s memory limit to the pod, thinking it would get killed when it passed 1.4GB of RAM, and reboot fresh, a decent-ish workaround for now.

Here's what happened instead:
image

Note that there's one other unusual thing here, I kubectl exec'ed several 200MB "ram balloon" processes to try to push it over the edge faster for testing. They clearly didn't work haha, and I doubt that's why this is not growing at the normal leakage rate, but worth mentioning.

Did something change or did adding a k8s memory limit suddenly change the behavior?

@snickell
Copy link
Author

(note this otherwise consistent memory growth pattern goes back to jan, and a number of version upgrades since from the z2jh chart..... this is.... weird)

@consideRatio
Copy link
Member

Hmmm, so when rhe pod restarts, is it because it has been evicted from a node, or is it because it has restarted its process within the container etc?

Being evicted from a node can happen based on external logic, while managing memory within the container can happen because of more internal logic, which can be enabled by limits to clairfy it needs to not surpass certain limits.

Need to learn more about OOMkiller things within the container vs by the kubelet etc, but perhaps you ended up helping it avoid getting evicted by surpassing its memory limit. Hmmm..

@rcthomas
Copy link
Contributor

rcthomas commented Jul 6, 2022

@snickell was what you observed related to load at all? Like, on weekend days do you observe this behavior? We're currently experiencing relatively-speaking high load on our deployment, and I observe something similar. Memory consumption in the proxy will just suddenly shoot up and it becomes non-responsive. Are you still using CHP for your proxy? I am considering swapping it for Traefik in the coming days here.

@consideRatio
Copy link
Member

consideRatio commented Jul 14, 2022

@snickell have you experienced this with older versions of z2jh -> chp as well?

@marcelofernandez
Copy link

Still happening on the latest version (v4.5.6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants