Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate button shows incomprehensible SyntaxError when the solution trips the timeout limit #1846

Open
lahwaacz opened this issue Nov 22, 2023 · 1 comment

Comments

@lahwaacz
Copy link
Contributor

Operating system

Arch Linux

nbgrader --version

Python version 3.11.5 (main, Sep  2 2023, 14:16:33) [GCC 13.2.1 20230801]
nbgrader version 0.9.1

jupyterhub --version (if used with JupyterHub)

4.0.2

jupyter notebook --version

7.0.6

Expected behavior

Nbgrader should not display a SyntaxError when some internal operation fails.

Actual behavior

When a student tries to validate an assignment that gets stuck due to infinite loop, Nbgrader shows this error:

Validation failed
Cannot validate: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

screenshot-2023-11-22@12:08:02

Steps to reproduce the behavior

Create an assignment with an infinite loop and click on "Validate":

while True:
    pass
@brichet
Copy link
Contributor

brichet commented Nov 30, 2023

On my side the test passes... and I don't think this is expected 😄

It should fail if the execution timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants