Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certain characters in assignment names break operations #1843

Open
perllaghu opened this issue Oct 27, 2023 · 0 comments
Open

certain characters in assignment names break operations #1843

perllaghu opened this issue Oct 27, 2023 · 0 comments

Comments

@perllaghu
Copy link
Contributor

perllaghu commented Oct 27, 2023

Tested under ubuntu, with a clean install of jupyterlab & nbgrader into a virtualenv

python 3.10.2
jupyter lab : 4.0.7
nbgrader 0.9.1

Expected behavior

If I can create an assignment name, then I should be able to release, submit, collect, and autograde a test notebook-document

Actual behavior

  • test 1/2 creates the folder source/test 1/2 (kinda obvious, if you are computer-aware, not all instructors are)
  • 123 (abc) allows a source to be created, generates, released, submits, collects...... but does not include the file in the count of collected files. The submission has been collected, however the code to count it trips over the parentheses.
  • 123 [abc] allows a source to be created, but gives an nbgrader.converters.base.NbGraderException: No notebooks were matched by '/tmp/nbtest/source/./123 [abc]' error during the generate process

My deduction is that the troublesome characters are those that throw the rexep used to scan for submission, etc.

... this is #1738 again

Steps to reproduce the behavior

Make a clean install, start jupyterlab, and test with a known-good assignment notebook-document.

Suggested correction

Scan assignment names on creation and exclude certain characters - ie, extend manage_assignments.js et al

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants