Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLab Git Extension #1464

Closed
kslader8 opened this issue Sep 14, 2021 · 6 comments · Fixed by #1895
Closed

JupyterLab Git Extension #1464

kslader8 opened this issue Sep 14, 2021 · 6 comments · Fixed by #1895
Labels
type:Enhancement A proposed enhancement to the docker images

Comments

@kslader8
Copy link

kslader8 commented Sep 14, 2021

What docker images this feature is applicable to?
jupyter/scipy-notebook

What changes do you propose?
installing jupyterlab-git
(mamba install jupyterlab-git)

How does this change will affect users?
It allows users to more easily collaborate (the main issue research teams I work on have with jupyterhub). I'm actually surprised that jupyterlab-git hasn't been absorbed into the default running of jupyter lab. It's a very wide value add and git is already installed in the minimal notebook.

The only downside is it isn't used by jupyter notebooks, but it's probably a good time to start incentivizing jupyter lab over jupyter notebooks.

@kslader8 kslader8 added the type:Enhancement A proposed enhancement to the docker images label Sep 14, 2021
@mathbunnyru
Copy link
Member

@kslader8 could you please draft a PR?
And could you check how the size of the image changes after adding this package?

We try to minimize the image size, especially minimal-notebook(it makes sense to add this to minimal notebook, because git is also installed there as you said).

@mathbunnyru
Copy link
Member

The author doesn't seem to be interested, so closing this issue.

@romeokienzler
Copy link
Contributor

romeokienzler commented Apr 25, 2023

@mathbunnyru Can you please re-open?

Created PR #1895

New size of image: 3.82 GB, previous size 3.78 GB

@costa
Copy link

costa commented Sep 5, 2023

I'm sorry to report that as of today, this extension does not seem to work (I'm not sure any other extensions work because I need just this one).

I run JupyuterLab "locally" all-fresh with:

version: '2.1'
services:
  jupy:
    image: jupyter/scipy-notebook
    command: start-notebook.sh --IdentityProvider.token=''

If anyone can verify this and prove me wrong/right — or provide any other assistance, it will be greatly appreciated.

Thank you.

@mathbunnyru
Copy link
Member

mathbunnyru commented Sep 5, 2023

@costa unfortunately, I don't think this extension was adapted for JupyterLab 4.x, which is now used in our images.
The upstream issue:
jupyterlab/jupyterlab-git#1245
If you can dedicate your time and help fixing the issue in the upstream project, that would be great.

If you want to use this extension with our images, you can either downgrade jupyterlab in an inherited image or use jupyter/scipy-notebook:lab-3.6.3 (this image is not up-to-date though).

@costa
Copy link

costa commented Sep 5, 2023

@mathbunnyru Thank you, subscribed to the upstream issue (I hope the Jupyter team will be much more efficient fixing it than myself could be), lab-3.6.3 seems to work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement A proposed enhancement to the docker images
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants