Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release instructions do not suggest to bump the model/view version numbers #84

Open
rmorshea opened this issue Jan 19, 2021 · 1 comment
Open

Release instructions do not suggest to bump the model/view version numbers #84

rmorshea opened this issue Jan 19, 2021 · 1 comment

Comments

@rmorshea
Copy link

The problems I was experiencing in #82 were a result of the fact that I had not bumped the model/view versions in the widget definition as suggested by @jasongrout. This is probably because the RELEASE.mdfile does not suggest doing so.
@jasongrout
Copy link
Member

Feel free to submit a PR to add such language where and how you would have found useful!

rmorshea added a commit to rmorshea/widget-cookiecutter that referenced this issue Jan 20, 2021
@rmorshea
Fixes jupyter-widgets#84
790e7b5 
- Improve formatting of RELEASE.md
- Add suggestion to bump view and model version in widget implementations
@rmorshea rmorshea mentioned this issue Jan 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add suggestion to bump view and model version in widget implementations rmorshea/widget-cookiecutter
2 participants
@jasongrout @rmorshea