Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JupyterLab extension files not bundled into pip package #58

Open
mbektas opened this issue Jan 10, 2020 · 1 comment
Open

JupyterLab extension files not bundled into pip package #58

mbektas opened this issue Jan 10, 2020 · 1 comment

Comments

@mbektas
Copy link
Member

mbektas commented Jan 10, 2020

we discovered this issue while working on documentation with @pbugnion. widget-cookiecutter is not including lab extension files into pip package unlike widget-ts-cookiecutter does in https://github.com/jupyter-widgets/widget-ts-cookiecutter/blob/master/%7B%7Bcookiecutter.github_project_name%7D%7D/setup.py#L49
@mbektas mbektas changed the title JupyterLab extension package not bundled into pip package JupyterLab extension files not bundled into pip package Jan 10, 2020
@martinRenou
Copy link
Member

I'd love to see this happen actually. This goes along with the discussion we had on ipywidgets jupyter-widgets/ipywidgets#2806. I've made this update in ipyleaflet and ipympl very recently. But it would be super nice if all widgets libraries do that, it would simplify things.

I can come up with a PR.

@ianhi ianhi mentioned this issue Jul 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinRenou @mbektas