Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning #40

Open
xoolive opened this issue Oct 7, 2019 · 8 comments · May be fixed by #41
Open

DeprecationWarning #40

xoolive opened this issue Oct 7, 2019 · 8 comments · May be fixed by #41

Comments

@xoolive
Copy link

xoolive commented Oct 7, 2019

dtype should not be instantiated here but as a .tag(dtype=...)

default_value=default_value, allow_none=allow_none, dtype=dtype, **kwargs)

PR could be pretty direct but I am not sure about the implications of such changes...

@xoolive
Copy link
Author

xoolive commented Oct 7, 2019

related to jupyter-widgets/ipyleaflet#414

@vidartf
Copy link
Member

vidartf commented Oct 7, 2019

@xoolive
Copy link
Author

xoolive commented Oct 7, 2019

Well the line doesn't hurt, I actually remove the dtype argument on my side, but the warning is still there:

[hidden]/lib/python3.7/site-packages/ipyleaflet-0.11.3-py3.7.egg/ipyleaflet/leaflet.py:316: DeprecationWarning: metadata {'dtype': None} was set from the constructor. With traitlets 4.1, metadata should be set using the .tag() method, e.g., Int().tag(key1='value1', key2='value2')
  data = Dataset().tag(sync=True, to_json=ds_x_to_json)

@vidartf
Copy link
Member

vidartf commented Oct 8, 2019

Ah. I see the issue:

@xoolive
Copy link
Author

xoolive commented Oct 8, 2019

sounds legit
you want me to do the PR or is it faster for you to just commit it?

@vidartf
Copy link
Member

vidartf commented Oct 8, 2019

I'm doing a web edit

@vidartf vidartf linked a pull request Oct 8, 2019 that will close this issue
@vidartf
Copy link
Member

vidartf commented Oct 8, 2019

Xref #41.

@surya-sigtech
Copy link

@vidartf
The issue (warning) is still there; are you planning to merge your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants