Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nan support #30

Open
maartenbreddels opened this issue Nov 8, 2018 · 0 comments
Open

nan support #30

maartenbreddels opened this issue Nov 8, 2018 · 0 comments

Comments

@maartenbreddels
Copy link
Member

if not np.array_equal(old_value, new_value):
will think arrays are not equal always when they contain a nan, the proper code might be sth like:

            try:
                return np.allclose(a, b, 0, 0, equal_nan=True)
            except (TypeError, ValueError):
                return False

There are more places around, like in ipywidgets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant