Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify cookiecutters? #4

Open
ianhi opened this issue Feb 18, 2021 · 1 comment
Open

Unify cookiecutters? #4

ianhi opened this issue Feb 18, 2021 · 1 comment

Comments

@ianhi
Copy link

ianhi commented Feb 18, 2021

Problem

The js and ts cookiecutters can easily get out of sync, for example the js cookiecutter uses widgets.register while the ts cookiecutter does not. Looking through them there are several PRs that apply to one but not the other, even if the same changes would apply equally. For instance the cookiecutters ought to have the same packaging, so PRs such as jupyter-widgets/widget-cookiecutter#87 will require duplicated effort.

Proposed Solution

Create a single cookiecutter that has an option to choose ts or js.

@jtpio
Copy link
Member

jtpio commented Mar 5, 2021

Thanks @ianhi for opening this issue.

This also came up for the JupyterLab cookiecutters when updating the JS cookiecutter to the new distribution system: jupyterlab/extension-cookiecutter-js#33 (comment)

Now extension-cookiecutter-js and extension-cookiecutter-ts are very similar. It was briefly discussed in this lab dev meeting whether or not they should be a single cookiecutter: jupyterlab/frontends-team-compass#117 (comment) (although there hasn't been any decision on this yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants