Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Design the workflow.proto #7

Open
Dr0p42 opened this issue Dec 5, 2023 · 1 comment · May be fixed by #8
Open

feat: Design the workflow.proto #7

Dr0p42 opened this issue Dec 5, 2023 · 1 comment · May be fixed by #8
Assignees
Labels
enhancement New feature or request

Comments

@Dr0p42
Copy link
Contributor

Dr0p42 commented Dec 5, 2023

Now that the scheduler-v2-poc is done, we can proceed to the implementation of that in the api.

For that we need to create the Workflow.proto that will contain the resources needed to build a DAG Workflow that will run in Argo Workflow.

We should follow the following documentation from Argo: https://argoproj.github.io/argo-workflows/walk-through/the-structure-of-workflow-specs/

Resources that should be taken in account for creating the protos are:

  • io.argoproj.workflow.v1alpha1.Workflow
  • io.argoproj.workflow.v1alpha1.WorkflowSpec
  • io.argoproj.workflow.v1alpha1.CronWorkflow
  • io.argoproj.workflow.v1alpha1.WorkflowSpec
  • io.argoproj.workflow.v1alpha1.Template

We must also be able to specify metadata but this will mainly be for us in the backend to pinpoint to which users are the workflow tied to etc.

As part of this you should also create all the CRUD messages (DTO) like WorkflowCreationRequest, WorkflowDeletionRequest etc ...

@viniciusdc please let me know if I am forgetting anything.

@Dr0p42 Dr0p42 added the enhancement New feature or request label Dec 5, 2023
@viniciusdc
Copy link
Contributor

Hi @Dr0p42 looks like you considered everything, I can't think of anything else that might be needed, but I am sure I will find it when they appear.

@viniciusdc viniciusdc linked a pull request Dec 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

2 participants