Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyvis - Three minor enhancements #2443

Closed
duxans opened this issue Dec 7, 2023 · 0 comments · Fixed by #2444 · May be fixed by #2458
Closed

Pyvis - Three minor enhancements #2443

duxans opened this issue Dec 7, 2023 · 0 comments · Fixed by #2444 · May be fixed by #2458
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@duxans
Copy link
Contributor

duxans commented Dec 7, 2023

Describe the bug
Not really bugs, just small improvements:

  • iterating over set(tools) for tool in set(tools): instead of for tool in tools: to avoid unecessary overwriting iterations. The same for notebooks for-loop.
  • remove physics=False leaving the default True for all regular tool nodes. This was set to False causing undesired freezing movement for two of the tool nodes.
  • change the string title for the edges that shows up when hovering with the cursor. Instead of the "action" string now will show the shorter and more informative "notebook_url" string.

Expected behavior
More efective workflow skipping overwriting and all tool nodes having correct physics settings for free movement. Better edge info.

@duxans duxans added bug Something isn't working enhancement New feature or request labels Dec 7, 2023
FlorentLvr added a commit that referenced this issue Dec 11, 2023
…hancements

fix: #2443 pyvis three minor enhancements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants