Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub release artifacts are not separate for jupyter-lsp and jupyterlab-lsp #1072

Closed
lahwaacz opened this issue Mar 23, 2024 · 1 comment
Closed

Comments

@lahwaacz
Copy link

Both jupyter-lsp-2.2.4.tar.gz and (jupyterlab-lsp) v5.1.0.tar.gz release artifacts have precisely the same structure - they include the whole git repository at the point of the release.

On the other hand, the jupyter-lsp-2.2.4.tar.gz file on PyPI contains just the python_packages/jupyter_lsp directory and jupyterlab-lsp-5.1.0.tar.gz on PyPI contains just the python_packages/jupyterlab_lsp directory.

Can you clarify what is the point of each different source release? What happens when I build a package from the top level directory of the git repository? Does it build both Python packages at once? Is there anything else being built?

@lahwaacz lahwaacz changed the title Release artifacts are not separate for jupyter-lsp and jupyterlab-lsp GitHub release artifacts are not separate for jupyter-lsp and jupyterlab-lsp Mar 23, 2024
@krassowski
Copy link
Member

These archives are auto-generated by GitHub. We do not have control over them as far as I know.

What happens when I build a package from the top level directory of the git repository

I think nothing much as this is not setup as a proper Python monorepo right now. You would need to build each package separately. If you wish to do so, currently this is done by these lines on CI:

- name: Build python distributions
run: |
set -eux
cp README.md python_packages/jupyterlab_lsp
cd python_packages/jupyter_lsp
python setup.py sdist bdist_wheel
cd ../jupyterlab_lsp
python setup.py sdist bdist_wheel

but subject to change to more modern tooling at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants