Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: GitLab Duo Code Suggestions via gitlab-lsp #1037

Open
nocnokneo opened this issue Jan 17, 2024 · 2 comments
Open

Feature request: GitLab Duo Code Suggestions via gitlab-lsp #1037

nocnokneo opened this issue Jan 17, 2024 · 2 comments
Labels
enhancement New feature or request feature:completion

Comments

@nocnokneo
Copy link

nocnokneo commented Jan 17, 2024

Description

Add support for GitLab Duo Code Suggestions via the GitLab Language Server

Expected behavior

gitlab-lsp suggestions work in together with existing traditional language-specific LSP servers.

@bollwyvl
Copy link
Collaborator

This would be a fine feature as an optional extension, but we likely don't have the ability to test it, and therefore, support it directly in this repo, without a raft of API tokens, etc.

@krassowski
Copy link
Member

@nocnokneo thanks for highlighting GitLab Duo Code Suggestions! We implemented inline code suggestions in JupyterLab 4.1 (jupyterlab/jupyterlab#15160) with the interfaces following the upcoming Language Server Protocol v3.18. The plan is to have an IInlineCompletionProvider in jupyterlab-lsp which would send textDocument/inlineCompletion requests; however before we merge such a new feature we would like to LSP v3.18 to be finalised and released - it is still in draft.

As for the GitLab Language Server, as @bollwyvl mentions it would be a bit higher barrier to merge out of the box support for it (this means auto-discovery and configuration specification) as it not necessarily something we can easily test, but if you would like to contribute a jupyter-lsp extension, we could host it in jupyter-lsp organization.

@krassowski krassowski added feature:completion enhancement New feature or request labels Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature:completion
Projects
None yet
Development

No branches or pull requests

3 participants