Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Implement LSP 3.17 notebook document support #1013

Open
zhanba opened this issue Nov 16, 2023 · 1 comment
Open

[Feature request] Implement LSP 3.17 notebook document support #1013

zhanba opened this issue Nov 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@zhanba
Copy link
Contributor

zhanba commented Nov 16, 2023

Elevator Pitch

LSP 3.17 have supported notebook document, maybe jupyter-lsp can implement it.

Motivation

  • By leverage LSP 3.17, the design of jupyterlab-lsp can be simplefied a lot! The VirtualDocument design is not necessary, the client implementation is much easier. Many lint and format problem introduced by VirtualDocument is not exist any more.
  • Ruff has recently support notebook(lint & format) by using LSP 3.17.

Design Ideas

@krassowski
Copy link
Member

the design of jupyterlab-lsp can be simplefied a lot!

At the cost of not working with majority of language servers, and having more complicated state for each individual cell. This is not straightforward, I looked into it a few times and while supporting this in a future is possibility, the cost/benefit ratio is not clear just yet.

@krassowski krassowski added the enhancement New feature or request label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants