-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: season 0 episodes that are automatically placed within seasons are scanned regardless of analyze season 0 setting and breaks manual fingerprint editor #82
Comments
I have a feeling that may be part of what is causing the issue. If Jellyfin is showing the specials as part of season 4, the plugin doesn't know they aren't. Jellyfin automatically reorders a special folder as index 0. The plugin checks that the first season detected is index 0 and (based on settings) whether to scan it or not. The problem is that you not only don't have the folder, but also that your specials are in season 4. That is what reorders season 4 to the top and breaks being able to opt out of scanning them. |
You also don't need the old custom web-ui. This one injects it into the stock build. I'll see what I can do about getting the manual editor to actually work. It was based on the assumption that chromaprint actually worked, but that's become more of a fallback. I don't know that there is much that can be done about how the server categorized specials, at least not without drastically increasing the scan time and some hacky logic. |
My specials are in a folder called "Specials", sorry if that was unclear, meant that I didnt have both. for family guy the directory structure is as follows: They are pulled into the season because thetvdb has a tag for "special position" to indicate where to place it in the library. See https://thetvdb.com/series/family-guy/episodes/181165 - special position places it "before season 4, episode 28" so in the Jellyfin library it is pulled from the specials index and placed in the season 4 index despite the fact that it is placed in a separate folder. I typically ignore scanning specials but these are getting scanned because of this. The only issue really I am having here is the fingerprint editor being broken as a result; a different show has this issue but the fingerprinting is off and I can't adjust the timings because only the special is selectable in the editor. will look into getting rid of the custom webui, thanks for the heads up! and either way thanks for your time!! |
Is this still an issue after all the recent changes? |
Same behavior with 0.1.17.0 |
Thanks. Ill take a fresh look |
Describe the bug
if an episode from season 0 is included within a season due to tvdb metadata it is automatically scanned, ignoring "analyze season 0" being unchecked despite absence of extras folder.
further, when going to change erroneous fingerprints within a season where this occurs it is not possible, the only episode that appears in the dropdown for the season is the one pulled from specials.
screenshot
screenshot of library showing what I mean - season 4 of family guy with the last 4 episodes replaced with the movie of the same episodes from specials
screenshot
screenshot
screenshot
once selected fingerprints for said episode do not load. this is inconsistent; I have gotten fingerprints for said episode to load.
also comes up for anime with OVAs released in-between seasons and that's where fingerprinting tends to be more problematic for me. I can autoskip what is believed to be the intro or get the skip intro button from patched webui to appear so everything is getting fingerprinted, just cannot access the fingerprints for episodes once they are fingerprinted
also thanks for maintaining this project!
Jellyfin installation method
docker
Container image and tag
jellyfin 10.8.13 bbergle image, introskipper 0.1.16+7032816cbeb6
Operating System
docker is debian base, running on unraid
Support Bundle
InvalidChromaprintFingerprint
okay
FFmpeg version:
Jellyfin logs
No response
The text was updated successfully, but these errors were encountered: