refactor intros/credits

[jumoog]

• own credit types
• merge credits.xml and intros.xml
• allow to edit credits times

[jumoog]

i just squashed some commits together. The repo looks okay for me

[AbandonedCart]

Oh okay. It looked like it had gotten force pushed with half new and half old stuff

[jumoog]

Why you can't use Jellyfin 10.9? You dont use the Docker image?

[AbandonedCart]

I have two Macs and a ROG Ally. The Mac with good internet is locked to 10.14 for Photoshop, The Mac with 12 has terrible internet. The Ally doesn't have the storage space

[AbandonedCart]

Docker is junk on Mac

[jumoog]

Yes, I know the pain. I rented a cheap server and can access Jellyfin on the go.

[AbandonedCart]

It would probably be good to make 10.9 the master branch and make 10.8 the 10.8 since usually the current is what you'd expect to be master

[jumoog]

Yes that was my plan.

[AbandonedCart]

I was looking at the manifest and it seems like 10.9 will install if you have 10.9 and anything less will install what is the master branch right now. Wouldn't that make it possible to have a 10.8 branch and a 10.9 branch with master more or less just being a shared manifest? Apparently it installs the newer one and tells me it's unsupported. So much for that

[AbandonedCart]

Since the 10.9 release effectively installs the 10.9 version, I fixed the structure so the 10.9 branch is now master and 10.8 is now the secondary branch. It was going to have to get done eventually and was already causing some confusion. The builds still get tagged as 10.8 and 10.9 to make them easy to tell apart.

[rlauuzo]

To ensure the correct version is installed on 10.9, should we consider bumping the version number up (e.g., 0.1.17) for the 10.9 release? This would allow to add v0.1.16.5 to the master manifest without it superseding the 10.9 version.

[jumoog]

To ensure the correct version is installed on 10.9, should we consider bumping the version number up (e.g., 0.1.17) for the 10.9 release? This would allow to add v0.1.16.5 to the master manifest without it superseding the 10.9 version.

Thats a brillant idea!

[AbandonedCart]

On the master branch, only 10.9 releases should be added to the manifest, but you might want to make it something more significant (ie. 0.2.01)

Didn't see that's what you did lol

[AbandonedCart]

The builders are fixed now. I forgot that they used the full tag in the download link.

One thing that still needs to be done is bringing the 10.8 changes into 10.9.
It's all merged, but may need to be updated

[rlauuzo]

If we remove 10.8 releases from the master branch manifest, users on 10.8 will not receive updates unless they manually switch to the 10.8 branch. Leaving it in should be ok, as users on 10.8 can only install plugins compatible with target API 10.8. For users on 10.9, they will automatically receive the version with the higher version number?

[jumoog]

For users on 10.9, they will automatically receive the version with the higher version number?

Yes!

[AbandonedCart]

Actually, 10.8 users will be forced to install the 10.9 version and it will appear as unsupported, so they will have to manually switch over anyway. I made the same assumption, but apparently Jellyfin's installer decided to just break the plugins instead.

[jumoog]

Until 10.9 is released, existing 10.8 users should not need to update the URL. 10.8 users can't install 10.9 Plugins. And for 10.9 0.2 is always the higest number. If someone installs a lower version its not our Problem.

[rlauuzo]

Actually, 10.8 users will be forced to install the 10.9 version and it will appear as unsupported, so they will have to manually switch over anyway. I made the same assumption, but apparently Jellyfin's installer decided to just break the plugins instead.

That's incorrect. Releases for 10.9 don't appear in 10.8; however, releases for 10.8 do appear in 10.9.

[jumoog]

I reported this Problem here: jellyfin/jellyfin#11331 but i dont think it will be fixed in 10.9

[AbandonedCart]

That's incorrect. Releases for 10.9 don't appear in 10.8; however, releases for 10.8 do appear in 10.9.

Care to explain how my server is 10.8 and I awoke to an unsupported error because the 10.9 plugin installed? I'm not speculating on how it should work. I'm telling you what happened.

The only alternative would be that the manifest was set incorrectly and the 10.8 version of .64 was being redirected to the 10.9 version, but that appears to be correct.

[AbandonedCart]

Should be able to turn off that automatic CodeQL now. I added a yml one that's compatible with 10.9. A few bugs need to be worked out, but it beats marking virtually every successful build failed.

[rlauuzo]

I'm noticing an issue with the Entrypoint on version 10.9. In 10.8, the log entry 'ConfusedPolarBear.Plugin.IntroSkipper.Entrypoint: Running startup enqueue' appears on start, but it's missing in 10.9. Is Entrypoint not working?

[AbandonedCart]

GitHub is semi broken at the moment.

[AbandonedCart]