Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Times offset in some countries - timezone issue? #29

Open
DFEvans opened this issue Jan 7, 2023 · 2 comments
Open

Times offset in some countries - timezone issue? #29

DFEvans opened this issue Jan 7, 2023 · 2 comments

Comments

@DFEvans
Copy link

DFEvans commented Jan 7, 2023

Searching locations in the UK, Ireland, and Portugal (at least) gives values that are offset by one hour.

For example, it should not take an hour to reach locations in central London from Kings Cross: https://direkt.bahn.guru/?origin=7001370

Nor locations near Dublin from Connolly station: https://direkt.bahn.guru/?origin=6000043

Nor locations in Lisbon from Entrecampos station: https://direkt.bahn.guru/?origin=9400289

(Oddly, this doesn't seem to be universal - the couple of countries in +2 timezones I checked seem to have sensible results)

@jgraham
Copy link

jgraham commented Mar 15, 2024

I notice that Paris Nord to London St Pancras gives the correct time, but London St Pancras to Paris Nord gives a time that's one hour too long.

@gijsk
Copy link

gijsk commented Mar 15, 2024

It looks like this is the frontend repo and it just outputs a duration value provided by the backend repo. The code at https://github.com/juliuste/api.direkt.bahn.guru/blob/9cbf5f2b573397cff96ccd5263acf9a71a326509/src/reachableFrom.js#L63 seems to be doing some of the maths here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants