Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time traveling is possible #35

Open
UnlimitedCookies opened this issue Jun 26, 2023 · 1 comment
Open

Time traveling is possible #35

UnlimitedCookies opened this issue Jun 26, 2023 · 1 comment

Comments

@UnlimitedCookies
Copy link

image

The link: https://bahn.guru/day?origin=HAMBURG&destination=K%C3%96LN&class=1&bc=2&age=Y&date=04.07.2023

What happened here?

@soerface
Copy link

Heyho,

I figured out that it's not a bug in bahn.guru, but in hafas-client.
The bug happens when:

  • A travel starts at one date and ends at another date, and
  • One part of the journey (a "leg") is completely in the next date.
    • In your case, there is probably one travel from Hamburg to Cologne on 2023-07-04, and then within Cologne another travel which starts and ends on 2023-07-05.

In this case, the parts of the journey that are taking place on the next day, are reported by hafas-client to happen on your departure day. Therefore, it looks to bahn.guru as if the journey ended in the early morning of your departure day.

I've opened an issue over at hafas-client and created a test which reproduces the bug, but I'm not yet sure how to fix it: public-transport/hafas-client#301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants