Where are .JuliaFormatter.toml files searched for?

[simsurace]

The docs are slightly unclear about this. They say in the workspace but what if there are several folders? I do have a repo with a toml file in one of my workspaces but the style is not respected --- formatting instead is done with the default very light setting.

[IanButterworth]

See domluna/JuliaFormatter.jl#771 for a pain point

[pfitzseb]

They say in the workspace but what if there are several folders?

In any workspace. Basically, if you can open the file from the file explorer in VS Code, we should be able to pick find it.

[IanButterworth]

I'm not sure I understand the rationale for the current design. AFAIU .JuliaFormatter.toml files are for specifying directory-specific formatting rules, so why would vscode not respect that?

Is it just that it's expected that people only have one folder (repo) open per workspace? I generally have many open.

[simsurace]

IIUC workspace is the top level in the VSCode explorer. If I have multiple folders open, does the extension look for the TOML in the same folder first?

[pfitzseb]

It doesn't matter how many workspace folders you have open. We're following the same behaviour as JuliaFormatter, except for never looking at the global config and not veering outside the bounds of the directory you have opened in VS Code (so the theoretically obvious way for adding a global config by creating a /.JuliaFormatter.toml also doesn't work).

The main motivation for that is that all format options need to be inside of your repo for reproducibility (otherwise formatting ends up flipflopping between N different configs). That's a decision we (I?) made a couple years back, but certainly nothing we couldn't revisit.

[IanButterworth]

not veering outside the bounds of the directory you have opened in VS Code

What if you have multiple directories open?

To be concrete, say I have these folders open in a single workspace:

• julia
• MyFoo

where julia doesn't use JuliaFormatter, so formatting on save isn't wanted, but MyFoo does, so formatting on save is wanted.

Currently the system doesn't accommodate this, as far as I know?

[IanButterworth]

To clarify, what I mean is that say julia had a .JuliaFormatter that disabled JuliaFormatter (which is what I've considered adding to julia)

[pfitzseb]

We're always searching up from the current file's path, IIRC. So in both cases you should get the appropriate config. If not, then that's a bug

[IanButterworth]

I confirm the bug then.

Saving .JuliaFormatter.toml in the root of the julia repo with

ignore = [""]

then saving say base/loading.jl will format that file.

[iago-lito]

I'm not sure I exactly confirm this, but since this issue was opened yesterday, I think it's the right place/time to report that julia formatter seems to have stopped respecting the .JuliaFormatter.toml sitting next to my Project.toml at the root of my package folder.. this week. (using native neovim lsp client)
Has anything changed recently regarding this?