Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots don't show up in Live Share #2895

Open
oschulz opened this issue May 23, 2022 · 5 comments · May be fixed by #2903
Open

Plots don't show up in Live Share #2895

oschulz opened this issue May 23, 2022 · 5 comments · May be fixed by #2903

Comments

@oschulz
Copy link

oschulz commented May 23, 2022

Plots don't show up for Live Share participants, it seems. Not sure if there's the Julia extension can do something about this, or if we have to wait for improvements in Live Share itself, though.

@pfitzseb
Copy link
Member

pfitzseb commented May 24, 2022

We can probably do something about this with the vsls API (docs), namely by informing guests about new plots via postActivity.

Unrelated, but did you notice any other parts of the extension that didn't work over live share?

@oschulz
Copy link
Author

oschulz commented May 24, 2022

We can probably do something about this with the vsls API

Thanks @pfitzseb, that would be awsome. We've started to use LiveShare more and more, it's really a great tool for both shared coding and shared data analysis (hence, need for plots :-) ).

Unrelated, but did you notice any other parts of the extension that didn't work over live share?

Yes, @edit and so on don't work because the path doesn't exist locally - but I don't get why VScode doesn't open it on the remote side.

@oschulz
Copy link
Author

oschulz commented May 24, 2022

CC @Cornelius-G, @waldie11 and @pbechtle who would be very happy about shared plots as well :-)

@Cornelius-G
Copy link

Unrelated, but did you notice any other parts of the extension that didn't work over live share?

We also had some problems with unwanted line breaks in the Julia REPL of the non-host users. All lines were broken at about half the width of the terminal, or so. I can't remember right now if it was just the REPL or also the terminal, so I'm not sure if it's an issue of the Julia extension.

@pfitzseb pfitzseb linked a pull request May 25, 2022 that will close this issue
@pfitzseb
Copy link
Member

Turns out we'll have to wait for Microsoft to white list this extension so we can use vsls at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants