Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: dsp::Limiter distorts if threshold >> 0.0 dBFS #1322

Open
1 task done
emezeske opened this issue Jan 1, 2024 · 0 comments
Open
1 task done

[Bug]: dsp::Limiter distorts if threshold >> 0.0 dBFS #1322

emezeske opened this issue Jan 1, 2024 · 0 comments

Comments

@emezeske
Copy link

emezeske commented Jan 1, 2024

Detailed steps on how to reproduce the bug

  1. Add a dsp::Limiter to a project that makes sound, and set its threshold to something like 100 dBFS, and set the release to something short like 4ms.
  2. Make sound
  3. Hear distortion

What is the expected behaviour?

I would expect that if the threshold is set to something really high like 100 dBFS, the limiter would just do nothing -- it would pass the audio through with no changes. But somehow it seems that the audio is getting massively amplified before the hard 0 dBFS clipper, causing significant distortion.

Operating systems

Windows

What versions of the operating systems?

Windows 11

Architectures

x86_64

Stacktrace

No response

Plug-in formats (if applicable)

No response

Plug-in host applications (DAWs) (if applicable)

No response

Testing on the develop branch

The bug is present on the develop branch

Code of Conduct

  • I agree to follow the Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant