Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[Bug] Access-Control-Allow-Origin:* not present in 404 response headers #209

Open
samuel-belcastro opened this issue Aug 1, 2017 · 3 comments

Comments

@samuel-belcastro
Copy link
Contributor

To reproduce:

  1. Send a HEAD request to a fake-s3 bucket file that does exist from a different origin than the bucket. Check the response headers and verify Access-Control-Allow-Origin:* is present.
  2. Send a HEAD request to a fake-s3 bucket file that does not exist from a different origin than the bucket. Access-Control-Allow-Origin:* is not present in the response headers.
@samuel-belcastro
Copy link
Contributor Author

@jubos I have a fix for GET and HEAD requests. If you see this as an important issue, let me know and I'll create a pull request and do the testing. Otherwise you can close this, and I will use my fork.

@jubos
Copy link
Owner

jubos commented Aug 5, 2017

Seems like a worthwhile fix, let me know when you have your diff ready.

@samuel-belcastro
Copy link
Contributor Author

Diff is ready: #217

Please let me know when you are able to get this merged in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants