Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable using vars as layer name #1028

Merged
merged 5 commits into from
May 19, 2024
Merged

enable using vars as layer name #1028

merged 5 commits into from
May 19, 2024

Conversation

wis
Copy link
Contributor

@wis wis commented May 11, 2024 •
edited

Describe your changes. Use imperative present tense.

enable using vars as layer name

potentially may partially fix #1027

Checklist

  • Add documentation to docs/config.adoc
    • Yes or N/A
  • Add example and basic docs to cfg_samples/kanata.kbd
    • Yes or N/A
  • Update error messages
    • Yes or N/A
      • error handling in layer_idx() (parser/src/cfg/mod.rs:1669) is bad and needs fixing/improving
  • Added tests, or did manual testing
    • Yes

@wis
enable using vars as layer name
4a1f17e 
error handling in layer_idx() (parser/src/cfg/mod.rs:1669) is bad and
needs fixing/improving
@wis wis marked this pull request as draft May 11, 2024 20:38
@wis
Copy link
Contributor Author

wis commented May 11, 2024

I would appreciate a review and possibly guidance on how to improve error handling and error messages in layer_idx()

jtroo
jtroo reviewed May 12, 2024
View reviewed changes
parser/src/cfg/mod.rs Outdated Show resolved Hide resolved
@wis wis marked this pull request as ready for review May 12, 2024 12:21
@wis wis changed the title [draft] enable using vars as layer name enable using vars as layer name May 12, 2024
@jtroo
Copy link
Owner

jtroo commented May 12, 2024

Please add a test in one (or both) of:

parser/src/cfg/tests.rs
src/tests/sim_tests/layer_sim_tests.rs

Otherwise LGTM :)

@jtroo jtroo merged commit 8730678 into jtroo:main May 19, 2024
4 checks passed
@gerhard-h gerhard-h mentioned this pull request May 20, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtroo jtroo jtroo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[parser] Bug: variables and concat don't get parsed correctly in the name part of a deflayermap definition
2 participants
@wis @jtroo