Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use custom sort func for portability #46

Merged
merged 6 commits into from
Jun 1, 2021
Merged

fix: use custom sort func for portability #46

merged 6 commits into from
Jun 1, 2021

Conversation

jthegedus
Copy link
Owner

@jthegedus jthegedus commented Jun 1, 2021 •
edited

Description

sort -V or sort --version-sort are not portable as discovered and documented in the asdf core. This PR introduces the workaround.

closes #45

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Usage examples

How Has This Been Tested?

Checklist:

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@jthegedus jthegedus merged commit 6002e50 into main Jun 1, 2021
@jthegedus jthegedus deleted the fix/sort-versions-incompat branch June 1, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sort -V is not portable
1 participant
@jthegedus