-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destroy listener on page change #27
Comments
any progress on this issue? |
Looking for this as well. Any news? |
@jtassin Using this mechanism, we can use the same coding pattern as suggested by puppeteer -
What do you think? I can raise the merge request if we agree. |
I have created new package @agabhane/puppeteer-pending-requests with above requirements and few enhancements. |
@agabhane your idea makes sense Their is a PR for a cleanup behaviour : #112 more or less like your idea "listener should get disposed when waitForAllXhrFinished() promise gets resolved". Your idea in puppeteer-pending-requests to add a timer is very good. |
No description provided.
The text was updated successfully, but these errors were encountered: