Deprecate stylistic rules in favor of @stylistic/eslint-plugin/@stylistic/eslint-plugin-jsx

[MichaelDeBoey]

@antfu has merged eslint-stylistic/eslint-stylistic#17, so I guess we can safely deprecate all stylistic rules now

In a next major release, we could remove these rules as well if we want

[ljharb]

Unless that plugin has support for the same eslint and node range as this plugin, i don’t think that’s necessarily the best choice.

[burtek]

This plugin:

eslint-plugin-react/package.json

Lines 80 to 85 in ca162fd

	"peerDependencies": {
	"eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8"
	},
	"engines": {
	"node": ">=4"
	},

Stylistic:

{
  "engines": {
    "node": "^16.0.0 || >=18.0.0"
  },
  "peerDependencies": {
    "eslint": ">=8.40.0"
  }
}

Which means stylistic has much more narrow range (which makes sense as the rules where migrated in eslint 8.40.0, so no point in using stylistic in earlier versions)

[ljharb]

The point would be so an eslint 7 user, eg, could migrate to stylistic without having to upgrade eslint at the same time, but sure, I'm not suggesting stylistic needs to make a change - it's just a reason i wouldn't want to screw over users of this plugin who would be unable to use stylistic.

[burtek]

@ljharb it would actually be better to deprecate those rules and disallow changes to them here, but keep them for some time - just as eslint does

[ljharb]

That's something to consider, but in the meantime it'd be good to run our tests for those rules, on stylistic's rules, so we can be sure they're actually equivalent.