Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(scope): logging "missing translation key" when ssr is enabled #750

Open
1 task done
mackelito opened this issue Feb 20, 2024 · 1 comment
Open
1 task done

Comments

@mackelito
Copy link

mackelito commented Feb 20, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Which Transloco package(s) are the source of the bug?

Transloco

Is this a regression?

No

Current behavior

when adding

        "server": "apps/consent-site/src/main.server.ts",
        "prerender": true,
        "ssr": {
          "entry": "apps/consent-site/server.ts"
        }

the console loops the error message "missing translation key" making it impossible to load the page.

Expected behavior

Should only log it once like in browser console.

Steps to reproduce

  • generate a new site with ssr enabled.
  • add transloco + config + loader as described in docs
  • serve and load the page

Please provide the environment you discovered this bug in

Transloco: 5.0.10
Angular: 17.0.5
Node: 18
Package Manager: npm
OS: macOS

I would like to make a pull request for this bug

Yes 🚀

@shaharkazaz
Copy link
Collaborator

@mackelito You are welcome to open a fix PR 🚀
In future issues please provide a reproduction link, it would be great if you can also attach one here 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants