Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(transloco): transloco pipe does not support loadingTpl when template is provided #723

Open
1 task done
edmondko opened this issue Oct 26, 2023 · 1 comment
Open
1 task done

Comments

@edmondko
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Which Transloco package(s) are the source of the bug?

Transloco

Is this a regression?

Yes

Current behavior

providers: [ provideTranslocoLoadingTpl('loading...'), ... ]
loading template is not shown when provided in component/module providers when | transloco pipe is used in templates.

Expected behavior

provided loading template is shown when | transloco pipe is used in template.
Before translations are loaded for lazy loaded modules components with their own scope.

Please provide a link to a minimal reproduction of the bug, if you won't provide a link the issue won't be handled.

https://codesandbox.io/s/ngneat-transloco-forked-543jvn?file=/src/app/lazy/lazy.component.html

Transloco Config

No response

Please provide the environment you discovered this bug in

Transloco: v5.0.0
Angular: 16.0.0
Node: 16.18.2
Package Manager: npm
OS: macos 13

Browser

No response

Additional context

No response

I would like to make a pull request for this bug

No

@shaharkazaz
Copy link
Collaborator

@edmondko The loading template is only supported when using the structural directive, I'll make it clearer in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants