-
Notifications
You must be signed in to change notification settings - Fork 7
Same package appears as both (CURRENT) and (DEFAULT) #12
Comments
Well, that's super weird. It obviously is not supposed to work like that. I just ran it here and it is working fine. I wonder if you either added some print statements in the |
Also, determining which packages are "the same" is a bit of a guess... Specifically, if you look at the regex that splits the names into basename, version, and extension, it is assuming that a space, _, or - separate the version from the basename.
This may need to be tweaked-for example, it treats a filename like Adobe_CC_2015_Lightroom_Install.pkg.zip like this:
So the "basename" is "Adobe_CC", the version is "2015_Lightroom_Install", and the extension is ".pkg.zip". In this case it's because underscores are matched with the LooseVersion then sorts these version numbers lexicographically, so the 2015 of one CC product matches any other. Lightroom ends up being less than Photoshop because L < P. This is potentially something that could be solved with a more refined regex, better package naming, or both. In YOUR case, I'm not sure based on the one example what is going on, but hopefully that will get you started. |
Seems to be happening for packages which follow a stricter naming convention, too:
I'll dig in with |
I mean, the relevant part to my mind is that |
I've never seen this happen before with jss_helper, but I just set it up on a new Mac and it appears to think that ALL policies are eligible for promotion. Upon selecting a policy, the same package is offered as both (CURRENT) and (DEFAULT).
The text was updated successfully, but these errors were encountered: