Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import validate improvement #1015

Open
pofider opened this issue Dec 16, 2022 · 0 comments
Open

Import validate improvement #1015

pofider opened this issue Dec 16, 2022 · 0 comments

Comments

@pofider
Copy link
Contributor

pofider commented Dec 16, 2022

The import validation doesn't check if entities are actually valid.

We could run the real import in the transaction and roll it back in the end, but I don't think this is a good idea writing to db when validating something.

The second thought was that we add collection.validate and rewrite current validations so this is possible.
However, this has the downside in that validating duplicated names won't work.

The last idea is that we create a new instance of a memory store (store.provider=memory) somehow and perform the import there. This should give us the best validation possible without touching physical DB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant